feat/step-hook-timeout-resumption#549
Merged
Merged
Conversation
…sentinel step_hook(on_timeout="return") now carries the hook deadline on its SuspensionSignal; the Celery step executor schedules a workflow resume at that deadline (triggered_by=step_hook_timeout). On re-execution past the deadline the call returns the STEP_HOOK_TIMEOUT sentinel instead of re-suspending, so a hook nobody resumes can no longer suspend a workflow forever. Default on_timeout="suspend" preserves existing behavior. Motivated by the 2026-07-02 FlowHunt incident: loop steps need a durable tick (suspend with deadline, wake early on resume_hook) that cannot hang when all external resumers die. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…diate resumes A deadline (countdown) resume_workflow task holds its singleton lock for the entire countdown, silently swallowing every immediate resume — including resume_hook wake-ups — enqueued for the same run in the meantime. Observed live: step_hook(on_timeout="return") ticks only advanced at deadline cadence because iteration wake-ups were dropped at enqueue. resume_workflow_task now dedupes on (run_id, dedup_scope); delayed resumes get scope "deadline", immediate ones "immediate". generate_lock applies signature defaults so existing callers keep matching keys. Extra resume executions remain harmless (try_claim_run drops all but the first). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.